From fdb9e953228bacedf7dfb78b1239e2c7b696355a Mon Sep 17 00:00:00 2001 From: shatfield4 Date: Fri, 17 Jan 2025 17:26:25 -0800 Subject: [PATCH 1/2] fix similarity score bug in lance/chroma dbs --- server/utils/vectorDbProviders/chroma/index.js | 4 ++-- server/utils/vectorDbProviders/lance/index.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/utils/vectorDbProviders/chroma/index.js b/server/utils/vectorDbProviders/chroma/index.js index f888d99ffa1..3abff0886e4 100644 --- a/server/utils/vectorDbProviders/chroma/index.js +++ b/server/utils/vectorDbProviders/chroma/index.js @@ -99,8 +99,8 @@ const Chroma = { }, distanceToSimilarity: function (distance = null) { if (distance === null || typeof distance !== "number") return 0.0; - if (distance >= 1.0) return 1; - if (distance <= 0) return 0; + if (distance >= 1.0) return 0; + if (distance <= 0) return 1; return 1 - distance; }, namespaceCount: async function (_namespace = null) { diff --git a/server/utils/vectorDbProviders/lance/index.js b/server/utils/vectorDbProviders/lance/index.js index e3f285478b7..a2a8fdecac8 100644 --- a/server/utils/vectorDbProviders/lance/index.js +++ b/server/utils/vectorDbProviders/lance/index.js @@ -28,8 +28,8 @@ const LanceDb = { }, distanceToSimilarity: function (distance = null) { if (distance === null || typeof distance !== "number") return 0.0; - if (distance >= 1.0) return 1; - if (distance <= 0) return 0; + if (distance >= 1.0) return 0; + if (distance <= 0) return 1; return 1 - distance; }, heartbeat: async function () { From 8064e0392d4f3f2d3463c536e778cd0aa658bfbb Mon Sep 17 00:00:00 2001 From: timothycarambat Date: Fri, 17 Jan 2025 18:27:33 -0800 Subject: [PATCH 2/2] batch lower bound case --- server/utils/vectorDbProviders/chroma/index.js | 4 ++-- server/utils/vectorDbProviders/lance/index.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/utils/vectorDbProviders/chroma/index.js b/server/utils/vectorDbProviders/chroma/index.js index 3abff0886e4..a47146ed889 100644 --- a/server/utils/vectorDbProviders/chroma/index.js +++ b/server/utils/vectorDbProviders/chroma/index.js @@ -99,8 +99,8 @@ const Chroma = { }, distanceToSimilarity: function (distance = null) { if (distance === null || typeof distance !== "number") return 0.0; - if (distance >= 1.0) return 0; - if (distance <= 0) return 1; + if (distance >= 1.0) return 1; + if (distance < 0) return 1 - Math.abs(distance); return 1 - distance; }, namespaceCount: async function (_namespace = null) { diff --git a/server/utils/vectorDbProviders/lance/index.js b/server/utils/vectorDbProviders/lance/index.js index a2a8fdecac8..c0e387f375e 100644 --- a/server/utils/vectorDbProviders/lance/index.js +++ b/server/utils/vectorDbProviders/lance/index.js @@ -28,8 +28,8 @@ const LanceDb = { }, distanceToSimilarity: function (distance = null) { if (distance === null || typeof distance !== "number") return 0.0; - if (distance >= 1.0) return 0; - if (distance <= 0) return 1; + if (distance >= 1.0) return 1; + if (distance < 0) return 1 - Math.abs(distance); return 1 - distance; }, heartbeat: async function () {