Add GPT-5 support #4307
Closed
Add GPT-5 support #4307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 11, 2025 16:22
- Introduced max_tokens handling in OpenAiLLM and OpenAIProvider classes. - Updated system settings to include OpenAiMaxTokens from environment variables. - Added tests for GPT-5 parameter construction logic.
|
While executing agent with GPT-5 (with temperature set as 1), I got the error: Does this PR implicitly fix it? |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4304
What is in this change?
Properly detects and handles gpt-5 models.
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes