MDEV-37244: Avoid page lookup after read #4213
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the desired page is not in the buffer pool, we would invoke
buf_read_page()
and look up the page inbuf_pool.page_hash
. It is more efficient to letbuf_read_page()
to return a buffer-fixed block (ornullptr
in case of a failure).Release Notes
InnoDB performance was slightly improved in workloads that involve loading data into the buffer pool.
How can this PR be tested?
I observed a few per cent improvement in a Sysbench
oltp_read_only
benchmark where the active working set did not fit in the buffer pool. I also observed reduced resource usage, as reported bytime(1)
.Basing the PR against the correct MariaDB version
main
branch.This is a performance bug fix that depends on some earlier refactoring d6aed21 and f27e9c8.
PR quality check