-
Notifications
You must be signed in to change notification settings - Fork 313
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
Users that are group admins for a group and part of that group can skip approval due to AdminExcludedRule logic
To Reproduce
- Add "user" and "admin" group
- Make the admin group a "Group admin"
- Set "admin" group as group Administrator
- Add user to both groups
- Try to book device with approval required
Expected behavior
Reservation should still require approval by resource admin
Current behavior
User skips approval as AdminExcludedRule return true for
$user->IsAdminFor($reservationUser)
Additional context
- LibreBooking version: 98b72b4
- Solution might be to split AdminExcludedRule into different cases
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working