From 6ff9ecf911227d48cd064076ee01f6aac93409a4 Mon Sep 17 00:00:00 2001 From: Liam Brady Date: Fri, 2 Jun 2023 13:28:21 -0400 Subject: [PATCH 1/2] address focus issues from spec review --- spec.bs | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/spec.bs b/spec.bs index 6d3af60b..e617d84c 100644 --- a/spec.bs +++ b/spec.bs @@ -1723,7 +1723,8 @@ the fenced frame boundary, which is a privacy leak. To avoid this, we effectivel Modify the [=get the focusable area=] algorithm. Add a new case to the switch statement:
-
If focus target is a [=fenced navigable container=] with a non-null [=fenced navigable container/fenced navigable=]
+
If focus target is a [=fenced navigable container=] with a non-null + [=fenced navigable container/fenced navigable=]

Return the [=fenced navigable container=]'s [=fenced navigable container/fenced navigable=]'s [=navigable/active document=].

@@ -1737,25 +1738,25 @@ the fenced frame boundary, which is a privacy leak. To avoid this, we effectivel Modify step 3 of the [=currently focused area of a top-level traversable=] algorithm to read: 3. While |candidate|'s [=focused area=] is either a [=navigable container=] with a non-null - [=navigable container/content navigable=] or a [=fenced navigable container=] with a non-null - [=fenced navigable container/fenced navigable=]: set |candidate| to the - [=navigable/active document=] of either that [=navigable container=]'s - [=navigable container/content navigable=] or that [=fenced navigable container=]'s - [=fenced navigable container/fenced navigable=], whichever is non-null. + [=navigable container/content navigable=] or a [=fenced navigable container=] with a non-null + [=fenced navigable container/fenced navigable=]: set |candidate| to the [=navigable/active + document=] of either that [=navigable container=]'s [=navigable container/content navigable=] + or that [=fenced navigable container=]'s [=fenced navigable container/fenced navigable=], + whichever is non-null.
Modify step 6 of the [=sequential focus navigation=] algorithm to read: - 6. If |candidate| is not null, then run the [=focusing steps=] for - |candidate| with [=focus-unfenced|unfenced=] set to true and return. + 6. If |candidate| is not null, then run the [=focusing steps=] for |candidate| with + [=focus-unfenced|unfenced=] set to true and return. Modify step 9 of the [=sequential focus navigation=] algorithm to read: - 9. Otherwise, |starting point| is a [=focusable area=] in a [=child navigable=] or - [=fenced navigable container/fenced navigable=]. Set |starting point| to that - [=child navigable=] or [=fenced navigable container/fenced navigable=]'s - [=traversable navigable/unfenced parent=] and return to the step labeled loop. + 9. Otherwise, |starting point| is a [=focusable area=] in a [=child navigable=] or [=fenced + navigable container/fenced navigable=]. Set |starting point| to that [=child navigable=]'s + [=navigable/parent=] or [=fenced navigable container/fenced navigable=]'s [=navigable/unfenced + parent=] and return to the step labeled loop.
From 75e4d0c758b780eb339e066518d442058e52ac4c Mon Sep 17 00:00:00 2001 From: Liam Brady Date: Mon, 5 Jun 2023 16:04:13 -0400 Subject: [PATCH 2/2] address review comments --- spec.bs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spec.bs b/spec.bs index e617d84c..543ae5ba 100644 --- a/spec.bs +++ b/spec.bs @@ -1753,10 +1753,10 @@ the fenced frame boundary, which is a privacy leak. To avoid this, we effectivel Modify step 9 of the [=sequential focus navigation=] algorithm to read: - 9. Otherwise, |starting point| is a [=focusable area=] in a [=child navigable=] or [=fenced - navigable container/fenced navigable=]. Set |starting point| to that [=child navigable=]'s - [=navigable/parent=] or [=fenced navigable container/fenced navigable=]'s [=navigable/unfenced - parent=] and return to the step labeled loop. + 9. Otherwise, |starting point| is a [=focusable area=] whose [=Node/node document=]'s [=node + navigable=] is a [=child navigable=] or [=fenced navigable container/fenced navigable=]. Set + |starting point| to that [=node navigable=]'s [=navigable/unfenced parent=] and return to the + step labeled loop.