From cfe5041bb60939bf4b60f596cdc61de7faf6ed1c Mon Sep 17 00:00:00 2001 From: rob1997 Date: Fri, 20 Sep 2024 17:16:56 +0300 Subject: [PATCH 1/2] possible fix --- .../Runtime/Plugins/Web3AuthSDK/Api/Web3AuthApi.cs | 2 ++ .../Web3.Unity Samples/Scenes/SampleLogin - Connect Modal.unity | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Api/Web3AuthApi.cs b/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Api/Web3AuthApi.cs index aaf4afea6..60c148b84 100644 --- a/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Api/Web3AuthApi.cs +++ b/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Api/Web3AuthApi.cs @@ -19,6 +19,8 @@ public static Web3AuthApi getInstance() public IEnumerator authorizeSession(string key, Action callback) { + // Wait for a single frame + yield return 0; //var requestURL = $"{baseAddress}/store/get?key={key}"; //var request = UnityWebRequest.Get(requestURL); WWWForm data = new WWWForm(); diff --git a/src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.6.0/Web3.Unity Samples/Scenes/SampleLogin - Connect Modal.unity b/src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.6.0/Web3.Unity Samples/Scenes/SampleLogin - Connect Modal.unity index 5e419c32a..e46227f67 100644 --- a/src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.6.0/Web3.Unity Samples/Scenes/SampleLogin - Connect Modal.unity +++ b/src/UnitySampleProject/Assets/Samples/web3.unity SDK/2.6.0/Web3.Unity Samples/Scenes/SampleLogin - Connect Modal.unity @@ -318,7 +318,7 @@ MonoBehaviour: m_Script: {fileID: 11500000, guid: b575a0ab50061014ca051bbfaf597ac2, type: 3} m_Name: m_EditorClassIdentifier: - connectOnInitialize: 0 + connectOnInitialize: 1 connectButton: {fileID: 1551748812896581000} --- !u!4 &1658652863 Transform: From ecf60dda2c8fc55b1970eebfc91023e59f06d0fa Mon Sep 17 00:00:00 2001 From: rob1997 Date: Mon, 23 Sep 2024 11:49:15 +0300 Subject: [PATCH 2/2] more fixes --- .../Runtime/Plugins/Web3AuthSDK/Web3Auth.cs | 8 +++++++- .../Runtime/Web3AuthProvider.cs | 10 +++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Web3Auth.cs b/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Web3Auth.cs index 4fb593eed..87608d1f8 100644 --- a/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Web3Auth.cs +++ b/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Plugins/Web3AuthSDK/Web3Auth.cs @@ -424,7 +424,13 @@ private void authorizeSession(string newSessionId) this.Enqueue(() => this.onLogin?.Invoke(this.web3AuthResponse)); } } - + else + { + this.Enqueue(() => this.onLogin?.Invoke(new Web3AuthResponse + { + error = "Failed to connect, session null." + })); + } }))); } } diff --git a/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Web3AuthProvider.cs b/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Web3AuthProvider.cs index 781088d6b..dd7046a49 100644 --- a/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Web3AuthProvider.cs +++ b/Packages/io.chainsafe.web3-unity.web3auth/Runtime/Web3AuthProvider.cs @@ -93,7 +93,15 @@ private void Cancel() private void OnLogin(Web3AuthResponse response) { - _connectTcs.SetResult(response); + if (string.IsNullOrEmpty(response.error)) + { + _connectTcs.SetResult(response); + } + + else + { + _connectTcs.SetException(new Web3Exception(response.error)); + } } ///