From 7d8979610715d121f51b32de63bdfe5f5572e624 Mon Sep 17 00:00:00 2001 From: Stefan Scheu Date: Mon, 3 Apr 2023 13:22:58 +0200 Subject: [PATCH 1/2] fix: fixed checking variable if is array and array key exists --- .../ProductList/ElasticSearch/AbstractElasticSearch.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php b/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php index 83c9b1421d7..87879f7d366 100644 --- a/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php +++ b/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php @@ -1268,7 +1268,7 @@ protected function convertBucketValues(array $bucket) $data['key_as_string'] = $bucket['key_as_string']; } elseif (is_array($reverseAggregationBucket) && array_key_exists('doc_count', $reverseAggregationBucket)) { // reverse aggregation $data['reverse_count'] = $reverseAggregationBucket['doc_count']; - } elseif (is_array($subAggregationBuckets['buckets'])) { // sub aggregations + } elseif (is_array($subAggregationBuckets) && array_key_exists('buckets', $subAggregationBuckets)) { // sub aggregations foreach ($subAggregationBuckets['buckets'] as $bucket) { $data[$subAggregationField][] = $this->convertBucketValues($bucket); } From 268ccb6b906bc8a0c9501640e920757b0910b63e Mon Sep 17 00:00:00 2001 From: Stefan Scheu Date: Tue, 16 May 2023 08:32:00 +0200 Subject: [PATCH 2/2] chore: fixed check for array key --- .../ProductList/ElasticSearch/AbstractElasticSearch.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php b/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php index 87879f7d366..c33114e026f 100644 --- a/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php +++ b/bundles/EcommerceFrameworkBundle/IndexService/ProductList/ElasticSearch/AbstractElasticSearch.php @@ -1268,7 +1268,7 @@ protected function convertBucketValues(array $bucket) $data['key_as_string'] = $bucket['key_as_string']; } elseif (is_array($reverseAggregationBucket) && array_key_exists('doc_count', $reverseAggregationBucket)) { // reverse aggregation $data['reverse_count'] = $reverseAggregationBucket['doc_count']; - } elseif (is_array($subAggregationBuckets) && array_key_exists('buckets', $subAggregationBuckets)) { // sub aggregations + } elseif (is_array($subAggregationBuckets) && isset($subAggregationBuckets['buckets'])) { // sub aggregations foreach ($subAggregationBuckets['buckets'] as $bucket) { $data[$subAggregationField][] = $this->convertBucketValues($bucket); }