chore: more verbose logging during certificate validation #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the certificate is not valid, log the reason why not.
Collaborator
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d0eff23
into
GoogleCloudPlatform:master
110 checks passed
cheftako
reviewed
Sep 22, 2025
| ctx := context.TODO() | ||
| log := klog.FromContext(ctx) | ||
| if len(key) == 0 || len(cert) == 0 || len(caCert) == 0 { | ||
| log.Error(fmt.Errorf("empty key, cert or caCert"), "key, cert or caCert is empty") |
Collaborator
There was a problem hiding this comment.
rather than mostly repeating ourselves in the string, maybe indicate that we are "returning the CACert as invalid" or some such?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificate is not valid, log the reason why not.