-
Notifications
You must be signed in to change notification settings - Fork 259
Migrate Kueue installation to use Helm chart #4542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shubpal07
merged 3 commits into
GoogleCloudPlatform:develop
from
shubpal07:shubham/kueue-on-helm
Oct 9, 2025
Merged
Migrate Kueue installation to use Helm chart #4542
shubpal07
merged 3 commits into
GoogleCloudPlatform:develop
from
shubpal07:shubham/kueue-on-helm
Oct 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytetwin
requested changes
Aug 19, 2025
shubpal07
commented
Oct 1, 2025
tools/cloud-build/daily-tests/ansible_playbooks/tasks/wait-for-startup-script.yml
Show resolved
Hide resolved
shubpal07
commented
Oct 1, 2025
Contributor
Author
|
Testing details after commit: 9adffe2 |
01cc91b to
e707661
Compare
bytetwin
requested changes
Oct 7, 2025
tools/cloud-build/daily-tests/ansible_playbooks/tasks/wait-for-startup-script.yml
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/test-validation/test-gke-job.yml
Outdated
Show resolved
Hide resolved
This commit refactors the Kueue scheduler installation, migrating it from manually managed static YAML files to the official Kueue Helm chart.
e707661 to
3dba1f2
Compare
shubpal07
commented
Oct 7, 2025
tools/cloud-build/daily-tests/ansible_playbooks/test-validation/test-gke-kueue-config.yml
Outdated
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/test-validation/test-gke-job.yml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
PR-test-gke-a2-highgpu-kueue (hpc-toolkit-dev) |
bytetwin
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Kueue installationto use the officialHelm chartinstead of manually maintained, static YAML files. This significantly improves maintainability, simplifies future upgrades, and aligns our toolkit with standard practices.The previous file-based system was brittle and made updating Kueue a risky, manual process.
Implementation
This change implements a two-stage installation pattern:
Stage 1 (Helm Install): The old file-based
install_kueuemodule is replaced with a new one that uses our generichelm_installmodule to deploy the official Kueue OCI chart.Stage 2 (Kubectl Configure): The existing
configure_kueuemodule is preserved to apply our dynamic, blueprint-specific CRDs (ResourceFlavor,ClusterQueue) after the Helm installation completes. A depends_on block was added to ensure correct ordering.As part of this, the old kueue-*.yaml manifest files and the local variables referencing them have been removed.
Validation
Successfully deployed and validated end-to-end using the
gke-a3-ultragpublueprint.Helm Release: Verified helm list shows the kueue release as deployed.
Custom Config: Verified kubectl get resourceflavor ,clusterqueue shows the correct, dynamically configured resources.
Performance: a final NCCL benchmark was run successfully, confirming expected hardware performance (~800 GB/s bus bandwidth).
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.