[firebase_performance] support v2 android embedding #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocbcotta
reviewed
Oct 4, 2019
|
|
||
| public static void registerWith(Registrar registrar) { | ||
| final MethodChannel channel = new MethodChannel(registrar.messenger(), CHANNEL_NAME); | ||
| channel.setMethodCallHandler(new io.flutter.plugins.firebaseperformance.FirebasePerformancePlugin()); |
There was a problem hiding this comment.
Any reason to not import the package for this class?
There was a problem hiding this comment.
This was just a placeholder until we decided how we wanted to handle the new embedding packages. I switched to just use the MethodCallHandler.
cyanglaz
approved these changes
Oct 8, 2019
| @@ -17,6 +17,17 @@ | |||
| <meta-data | |||
| android:name="io.flutter.app.android.SplashScreenUntilFirstFrame" | |||
| android:value="true" /> | |||
| <!--<intent-filter>--> | |||
There was a problem hiding this comment.
nits: This doesn't seem to be necessary.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes flutter/flutter#41858
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?