这是indexloc提供的服务，不要输入任何密码
Skip to content

[firebase_storage] Support Android v2 embedding #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 2, 2019
Merged

[firebase_storage] Support Android v2 embedding #1295

merged 7 commits into from
Dec 2, 2019

Conversation

kroikie
Copy link
Collaborator

@kroikie kroikie commented Oct 21, 2019

xster
xster reviewed Oct 30, 2019
View reviewed changes
Copy link
Contributor

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/firebase_storage/example/pubspec.yaml Outdated
@@ -10,6 +10,7 @@ dependencies:
firebase_core: ^0.4.0
uuid: ^1.0.0
http: ^0.12.0
e2e: ^0.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a dev_dependency?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@xster
Copy link
Contributor

xster commented Nov 11, 2019

Reminder to sync and merge this

@kroikie
Copy link
Collaborator Author

kroikie commented Nov 11, 2019

Once the build is green, I'll rebase and merge this PR.

@kroikie kroikie force-pushed the firebase_storage_v2_embedding branch from 2c50ab4 to eb6d861 Compare November 20, 2019 00:29
@kroikie kroikie force-pushed the firebase_storage_v2_embedding branch from 7c0406f to 1f5b4d6 Compare November 27, 2019 00:49
@kroikie kroikie force-pushed the firebase_storage_v2_embedding branch from 1f5b4d6 to 6154776 Compare November 27, 2019 20:08
@kroikie kroikie merged commit af8e04a into master Dec 2, 2019
@kroikie kroikie deleted the firebase_storage_v2_embedding branch December 2, 2019 23:09
@creativecreatorormaybenot creativecreatorormaybenot mentioned this pull request Dec 15, 2019
Merged
12 tasks
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster xster left review comments

@collinjackson collinjackson collinjackson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[firebase_storage] Support the v2 Android embedder plugins API
4 participants
@kroikie @xster @collinjackson @googlebot