Attachment 34739 Details for Bug 19131 – patch with "no test" changelog comment removed

[patch] patch with "no test" changelog comment removed

19131.patch (text/plain), 1.53 KB, created by Patrick Mueller on 2009-08-13 07:29:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Mueller

Created: 2009-08-13 07:29:41 PDT

Size: 1.53 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 47140)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2009-08-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a new gesture in Web Inspector to remove breakpoints
>+        https://bugs.webkit.org/show_bug.cgi?id=19131
>+        
>+        * inspector/front-end/SourceFrame.js:
>+        (WebInspector.SourceFrame.prototype._documentMouseDown):
>+
> 2009-08-12  Lyon Chen  <lyon.chen@torchmobile.com>
> 
>         Reviewed by George Staikos.
>Index: WebCore/inspector/front-end/SourceFrame.js
>===================================================================
>--- WebCore/inspector/front-end/SourceFrame.js	(revision 47060)
>+++ WebCore/inspector/front-end/SourceFrame.js	(working copy)
>@@ -289,8 +289,10 @@ WebInspector.SourceFrame.prototype = {
>             return;
> 
>         var sourceRow = event.target.enclosingNodeOrSelfWithNodeName("tr");
>-        if (sourceRow._breakpointObject)
>-            sourceRow._breakpointObject.enabled = !sourceRow._breakpointObject.enabled;
>+        if (sourceRow._breakpointObject && sourceRow._breakpointObject.enabled)
>+            sourceRow._breakpointObject.enabled = false;
>+        else if (sourceRow._breakpointObject) 
>+            WebInspector.panels.scripts.removeBreakpoint(sourceRow._breakpointObject);
>         else if (this.addBreakpointDelegate)
>             this.addBreakpointDelegate(this.lineNumberForSourceRow(sourceRow));
>     },

Actions: View | Formatted Diff | Diff

Attachments on bug 19131: 34682 | 34739