这是indexloc提供的服务,不要输入任何密码
Skip to content

The 3ds2 dependency breaks Firebase Performance and Robolectric #1141

@romainpiel

Description

@romainpiel

Summary

Upgrading Stripe to version 9.3.5 (or any version after 9.1.1) breaks our app. The 3ds2 dependency added transitively the dependency to org.bouncycastle:bcprov-jdk15on:1.61. This forces a few other dependency to use that version and breaks the app in different ways:

  • The Firebase performance plugin (version 1.1.5) fails to load with the following error:
/.../app/build/intermediates/transforms/FirebasePerformancePlugin/release/162/module-info.class: D8: Unsupported source file type
  • The robolectric (version 4.0.2) tests take a very long time to run (~15 minutes per test)

Screenshot 2019-06-28 at 11 56 20

Android version

minSdk 21

SDK version

Version 9.1.1 to 9.3.5

Other information

I managed to work around both issues by forcing the bouncy castle dependency to 1.52.
Forcing the version to 1.52 shows an issue with Lint:

Invalid package reference in library; not included in Android: javax.naming.directory. Referenced from org.bouncycastle.jce.provider.X509LDAPCertStoreSpi.

But I imagine we can safely ignore it as I don't assume we do LDAP with Stripe.

Metadata

Metadata

Labels

triagedIssue has been reviewed by Stripe and is being tracked internally

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions