-
Notifications
You must be signed in to change notification settings - Fork 677
Closed
Labels
triagedIssue has been reviewed by Stripe and is being tracked internallyIssue has been reviewed by Stripe and is being tracked internally
Description
Summary
Upgrading Stripe to version 9.3.5 (or any version after 9.1.1) breaks our app. The 3ds2 dependency added transitively the dependency to org.bouncycastle:bcprov-jdk15on:1.61
. This forces a few other dependency to use that version and breaks the app in different ways:
- The Firebase performance plugin (version 1.1.5) fails to load with the following error:
/.../app/build/intermediates/transforms/FirebasePerformancePlugin/release/162/module-info.class: D8: Unsupported source file type
- The robolectric (version 4.0.2) tests take a very long time to run (~15 minutes per test)
Android version
minSdk 21
SDK version
Version 9.1.1 to 9.3.5
Other information
I managed to work around both issues by forcing the bouncy castle dependency to 1.52.
Forcing the version to 1.52 shows an issue with Lint:
Invalid package reference in library; not included in Android: javax.naming.directory. Referenced from org.bouncycastle.jce.provider.X509LDAPCertStoreSpi.
But I imagine we can safely ignore it as I don't assume we do LDAP with Stripe.
Ahmed-Abdelmeged and JulienDev
Metadata
Metadata
Assignees
Labels
triagedIssue has been reviewed by Stripe and is being tracked internallyIssue has been reviewed by Stripe and is being tracked internally