这是indexloc提供的服务，不要输入任何密码
Skip to content

DynamicLink initializer shouldn't be available from Swift #10000

New issue
New issue
Closed
#10236
Closed
DynamicLink initializer shouldn't be available from Swift#10000
#10236
Assignees
andrewheard
Labels
Swift APIapi: dynamiclinks
Milestone
Firebase 10 - M122
@ryanwilson

Description

@ryanwilson
ryanwilson
opened on Jul 12, 2022

There's no init marked as NS_UNAVAILABLE, so a bare initializer is currently available in Swift but shouldn't be.

firebase-ios-sdk/FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FIRDynamicLink.h

Lines 55 to 86 in 8467858

NS_SWIFT_NAME(DynamicLink)
@interface FIRDynamicLink : NSObject
/**
* @property url
* @abstract The URL that was passed to the app.
*/
@property(nonatomic, copy, readonly, nullable) NSURL *url;
/**
* @property matchType
* @abstract The match type of the received Dynamic Link.
*/
@property(nonatomic, assign, readonly) FIRDLMatchType matchType;
/**
* @property utmParametersDictionary
* @abstract UTM parameters associated with a Firebase Dynamic Link.
*/
@property(nonatomic, copy, readonly) NSDictionary<NSString *, id> *utmParametersDictionary;
/**
* @property minimumAppVersion
* @abstract The minimum iOS application version that supports the Dynamic Link. This is retrieved
* from the imv= parameter of the Dynamic Link URL. Note: This is not the minimum iOS system
* version, but the minimum app version. If app version of the opening app is less than the
* value of this property, then app expected to open AppStore to allow user to download most
* recent version. App can notify or ask user before opening AppStore.
*/
@property(nonatomic, copy, readonly, nullable) NSString *minimumAppVersion;
@end

We'll need to determine the right strategy for this: it's a breaking change to remove it, but it doesn't work as is. Introducing an initializer that's deprecated will introduce the API for ObjC users, which we don't want either.

Metadata

Metadata

Assignees

Labels

Swift APIapi: dynamiclinks

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions