这是indexloc提供的服务,不要输入任何密码
Skip to content

[FirebaseAI] Add support for Grounding with Google Search #15014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 4, 2025
Merged

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jun 20, 2025

API Proposal: go/fal-grounding-api (internal)

  • Added GoogleSearch tool and .googleSearch() static initializer
  • Added GroundingMetadata and related structs to store grounded results

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@dlarocque dlarocque marked this pull request as ready for review June 20, 2025 19:44
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces support for Grounding with Google Search, including new data structures and tool configurations. The changes include updates to the CHANGELOG, modifications to the GenerateContentResponse and Tool files, and the addition of new unit tests. The code appears well-structured and includes appropriate documentation.

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick pass before heading out. Looking good so far, just nits!

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and will defer to @andrewheard for approval

Do all of the new optional fields need to be optional?

Separate from this PR, this feature should be added to https://github.com/firebase/quickstart-ios/tree/main/firebaseai to show an example of complying with the UI requirements.

@dlarocque dlarocque requested a review from andrewheard June 23, 2025 15:57
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please resolve the warnings that were introduced in the tests.

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@dlarocque dlarocque merged commit a2db3ae into main Jul 4, 2025
55 of 62 checks passed
@dlarocque dlarocque deleted the dl/grounding branch July 4, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants