-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[FirebaseAI] Add support for Grounding with Google Search #15014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces support for Grounding with Google Search, including new data structures and tool configurations. The changes include updates to the CHANGELOG, modifications to the GenerateContentResponse
and Tool
files, and the addition of new unit tests. The code appears well-structured and includes appropriate documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a quick pass before heading out. Looking good so far, just nits!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and will defer to @andrewheard for approval
Do all of the new optional fields need to be optional?
Separate from this PR, this feature should be added to https://github.com/firebase/quickstart-ios/tree/main/firebaseai to show an example of complying with the UI requirements.
FirebaseAI/Tests/Unit/vertexai-sdk-test-data/mock-responses/developerapi
Outdated
Show resolved
Hide resolved
FirebaseAI/Tests/Unit/vertexai-sdk-test-data/mock-responses/vertexai
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please resolve the warnings that were introduced in the tests.
FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚢
API Proposal: go/fal-grounding-api (internal)
GoogleSearch
tool and.googleSearch()
static initializerGroundingMetadata
and related structs to store grounded results