update keychain access level #4172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymmalyhin
approved these changes
Oct 25, 2019
| @@ -74,22 +74,19 @@ NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| /** | |||
| * Set the data for a given service and account with a specific accessibility. If | |||
| * accessibility is NULL we use `kSecAttrAccessibleAlwaysThisDeviceOnly` which | |||
| * accessibility is NULL we use `kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly` which | |||
There was a problem hiding this comment.
Looks like the comment should be updated after removing accessibility parameter.
|
Yeah, I've tested with an existing keychain store and seems working well with settings updated. We've updated keychain access in the past and haven't seen any regression issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4167 user reports getting IID becomes nil when a token exists. We suspect this is due to a security issue while keychain access level is set to kSecAttrAccessibleAlwaysThisDeviceOnly that is deprecated in iOS 13. Neitherless we should update it to kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly since app only works in foreground so this is the proper access.
Also remove a parameter to set a optional access level for keychain cuz this parameter was never used.